adriangb commented on issue #21207: URL: https://github.com/apache/datafusion/issues/21207#issuecomment-4313901836
@jayshrivastava I'm happy to go with your PR or mine. I added the implementations in `HashJoinExec` and `SortExec` because they're necessary to show e2e working, which is needed to justify lower level changes. Since https://github.com/apache/datafusion/pull/21786 proves this approach works I think we can go with something like https://github.com/apache/datafusion/pull/21807. I'll review https://github.com/apache/datafusion/pull/21807. I'm unsure about #21055, I didn't seem to need to do that in https://github.com/apache/datafusion/pull/21786 but maybe I'm missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
