adriangb commented on issue #21207: URL: https://github.com/apache/datafusion/issues/21207#issuecomment-4299031280
> I preserve backwards compatability (ex. using the session id to salt the IDs, and deduping non-DynamicFilterPhysicalExpr). If we don't do this, we'd need to delete a bunch of tests from roundtrip_physical_plan.rs Given the existing functionality was completely broken by design and afaik no one is using it, maybe we can just break it? We'll check with Andrew before going forward but I think a clean slate might be best. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
