Neer393 commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3014977933
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapCacheMetadataSerializer.java:
##########
@@ -168,8 +169,15 @@ private static DiskRangeList
decodeRanges(List<LlapDaemonProtocolProtos.CacheEnt
}
private static CacheTag decodeCacheTag(LlapDaemonProtocolProtos.CacheTag ct)
{
- return ct.getPartitionDescCount() == 0 ? CacheTag.build(ct.getTableName())
: CacheTag
Review Comment:
I don't think it would be an issue. I think we should document that post
upgrade LLAP daemons would need a restart to flush the cache. This however does
not have any functional impact. Worst case if the user does not restarts, they
would face cache miss but no SQL job failures as far as I think.
@deniskuzZ any idea on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
