Neer393 commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3004214531
##########
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestCacheContentsTracker.java:
##########
@@ -127,7 +130,7 @@ public void testCacheTagComparison() {
public void testEncodingDecoding() throws Exception {
LinkedHashMap<String, String> partDescs = new LinkedHashMap<>();
partDescs.put("pytha=goras", "a2+b2=c2");
- CacheTag tag = CacheTag.build("math.rules", partDescs);
+ CacheTag tag = CacheTag.build(Warehouse.DEFAULT_CATALOG_NAME +
".math.rules", partDescs);
Review Comment:
Cannot push `Warehouse.DEFAULT_CATALOG_NAME` inside of CacheTag.build as
CacheTag sits in `hive-storage-api` module and Warehouse.DEFAULT_CATALOG_NAME
sits in `hive-standalone-metastore-common` module which is dependent on
`hive-storage-api` module. Adding this would create a circular dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
