zhangbutao commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3013151338
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapCacheMetadataSerializer.java:
##########
@@ -168,8 +169,15 @@ private static DiskRangeList
decodeRanges(List<LlapDaemonProtocolProtos.CacheEnt
}
private static CacheTag decodeCacheTag(LlapDaemonProtocolProtos.CacheTag ct)
{
- return ct.getPartitionDescCount() == 0 ? CacheTag.build(ct.getTableName())
: CacheTag
Review Comment:
What about handling old cached data? Will there be any compatibility issues
here?
I'm not very familiar with LLAP caching—perhaps a cache decoding failure
won't cause user sql jobs to fail? Maybe we just need to restart LLAP to update
the cache?
##########
ql/src/java/org/apache/hadoop/hive/llap/ProactiveEviction.java:
##########
@@ -233,19 +258,26 @@ public
List<LlapDaemonProtocolProtos.EvictEntityRequestProto> toProtoRequests()
* @return true if cacheTag matches and the related buffer is eligible for
proactive eviction, false otherwise.
*/
public boolean isTagMatch(CacheTag cacheTag) {
+ String catalog = getSingleCatalogName();
Review Comment:
There is a key issue that needs to be further optimized in the future: `not
all catalogs support caching`. Currently, I assume that only the native catalog
supports caching, while some other catalogs, such as the JDBC catalog, may have
difficulty supporting caching.
So I think we can create a ticket to record this issue.
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java:
##########
@@ -199,6 +219,14 @@ public int getBucketingVersion() {
properties.getProperty(hive_metastoreConstants.TABLE_BUCKETING_VERSION));
}
+ public String getCatalogName() {
+ return catalogName;
+ }
+
+ public void setCatalogName(String catalogName) {
Review Comment:
Where is this method used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
