Neer393 commented on code in PR #6379:
URL: https://github.com/apache/hive/pull/6379#discussion_r3004247917
##########
llap-server/src/test/org/apache/hadoop/hive/llap/io/api/impl/TestLlapCacheMetadataSerializer.java:
##########
@@ -107,7 +107,7 @@ private LlapDaemonProtocolProtos.CacheEntryList
createDummyMetadata() throws IOE
LlapDaemonProtocolProtos.CacheEntryRange re2 =
LlapDaemonProtocolProtos.CacheEntryRange.newBuilder().setStart(14L).setEnd(38L).build();
LlapDaemonProtocolProtos.CacheTag ct =
-
LlapDaemonProtocolProtos.CacheTag.newBuilder().setTableName("dummyTable").build();
+
LlapDaemonProtocolProtos.CacheTag.newBuilder().setTableName("hive.default.dummyTable").build();
Review Comment:
LlapDaemonProtocolProtos is a generated file from the
LlapDaemonProtocol.proto file which takes in table name as whole. So we can't
handle defaults
```
message CacheTag {
optional string table_name = 1;
repeated string partition_desc = 2;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
