jeanouii commented on code in PR #1563:
URL: https://github.com/apache/activemq/pull/1563#discussion_r2792781589
##########
.github/workflows/ci-nightly.yml:
##########
@@ -69,7 +69,7 @@ jobs:
java-version: ${{ matrix.java-version }}
distribution: temurin
- name: Test
- run: mvn -B -e -fae test
+ run: mvn -B -e -fae verify
Review Comment:
Yes it was mostly due to the introduction of failsafe to delay the execution
of tests using the MRJAR because the jar is created only after the test phase.
So tests using MRJAR were postponed to run only during the integration test
phase. So if you use test and not verify you won't run them.
In the end, I could have reverted this because Robbie requested instead to
change the phase of the JAR plugin so the MRJAR is built in the process classes
phase and therefor it's visible to the test plugin. Does not hurt. Could have
been removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
