gemmellr commented on PR #1563: URL: https://github.com/apache/activemq/pull/1563#issuecomment-3879789951
> @gemmellr I've now added the enforcer plugin in the apache-release profile to make sure we release the MRJAR supporting Java 21 and Java 24. I've removed the rule for the Maven version even though to be honest, I prefer it to be explicit like plugin versions or java compiler version. It's a personal preference and I'm fine if community prefers to yank it. Let me know if that's ok, so I can create the issue in JIRA and then, squash update the commit messages to clean everything up There is a property used in the parent for the maven version enforcement, you could set that if you wanted it to be specified locally more obviously. It is personal preference as you say. I dont know what others here might prefer. I definitely prefer to use the parent pom for a lot that is possible (but not everything; I set/override the compiler properties locally) in order to make our poms more concise. Most especially all the plugin versions possible. Users dont really [need to] care about _our_ plugin versions (they have their own plugin versions) so long as things still work, and the [constant plugin version upgrade churn](https://github.com/apache/activemq/pulls?q=is%3Apr+in%3Atitle+%22plugin%22) otherwise mostly just distracts from other far more meaningful dependency etc changes that users actually are more affected by and likely to be more interested in. I find using the parent versions removes a bunch of that noise, and using the same parent across different components can also mean more consistency among which plugins are being used (albeit, in general all the plugins do then use wildly inconsistent deps, so you stil l end up needing to grab lots of different versions of the same plugin deps regardless). Its still trivial to see what is actually being used with e.g help:effective-pom, or just running the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
