gemmellr commented on PR #1563: URL: https://github.com/apache/activemq/pull/1563#issuecomment-3872843889
I'll leave the test config changes to Matt, not sure whats wanted or has been discussed there. It doesnt look like you covered this bit of my earlier review. Either the original PR needs updated and merged before this one so this can update things, or this one should just do the necessary, to avoid a repeat of the previous releasing issue. > This should really be enforcing that Java 24+ is used for the release process since its required for this to be of any worth to end users. > > An earlier PR is still open to require 21+ since Java 21+ wasnt used for the previous release when it should have been, though that PR (#1532) requires changes as its somewhat [out of date now](https://github.com/apache/activemq/pull/1532#discussion_r2727819960) > > (I required 25 to release elsewhere, saves changing it later and noone should be really be using 24 now anyway) https://github.com/apache/activemq/pull/1563#pullrequestreview-3755585650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
