jbonofre commented on code in PR #1563:
URL: https://github.com/apache/activemq/pull/1563#discussion_r2792702509
##########
.github/workflows/ci-quick.yml:
##########
@@ -64,10 +64,11 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v4
with:
- java-version: 17
+ # temporary using 25 until all tests pass on Java 25 - to be changed
back to 17 for quick. 25 will run nightly only
+ java-version: 25
distribution: temurin
- name: Test
- run: mvn -B -e -fae test
+ run: mvn -B -e -fae verify -Pactivemq.tests-quick
Review Comment:
I agree with using `activemq.tests-quick` profile. Just curious about
`verify` vs `test`.
##########
.github/workflows/ci-nightly.yml:
##########
@@ -69,7 +69,7 @@ jobs:
java-version: ${{ matrix.java-version }}
distribution: temurin
- name: Test
- run: mvn -B -e -fae test
+ run: mvn -B -e -fae verify
Review Comment:
Any specific reason to use `verify` here more than `test` ? I'm just curious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
