Stefano,

I have applied your patch to GeoTools master.
https://github.com/geotools/geotools/commit/e87ff09fd970dcda3d1aa0cea0497d1ef62b0316

I have not been able to identify the difference that allows a nested 
feature to work properly in GeoSciML 2 and yet fail for GeologyCore. 
Top-level features have special treatment, but the situation is quite 
similar for the nested feature. Perhaps some subtle difference in 
cardinality or substitution group handling? The code base is very 
complicated.

Your fix certainly works for this case (tested manually against a 
property file configuration based on your mapping file), and only 
changes the behaviour of the method when all else fails, so I am quite 
happy with it.

Kind regards,
Ben.

On 15/07/15 01:38, stefano.costa wrote:
> I created a patch to fix this, by taking the type definition from the element 
> declaration that is passed as an argument to the 
> AbstractFeatureType_getProperties method: in my case, this solves the 
> problem, but I'm not at all sure this approach is correct (I'll frankly admit 
> I don't fully understand what the code is doing here).
> I'm attaching an updated version of the mapping file and the patch in diff 
> format: if you think it's useful, I can make a PR.

-- 
Ben Caradoc-Davies <[email protected]>
Director
Transient Software Limited <http://transient.nz/>
New Zealand

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Geoserver-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-users

Reply via email to