Hi Justin, Thanks for the vote. It looks like we forgot to remove the mentions of the resolved issues in the DISCLAIMER-WIP. Checking the linked issues, all of them have been resolved in 1.8. Is this still a blocking issue if the actual issues that the DISCLAIMER-WIP links to are addressed?
Between 1.8 submodules [1] and that of 1.7 [2] there hasn't been any addition of submodule. For the four modules with updated commits (dmlc-core, mkldnn, nvidia-cub, onnx-tensorrt), I didn't find any license change. What's missing? Regarding NVIDIA licensing, I'm not sure what the standard practice is given that we are indeed open sourcing our GPU source code with ALv2 and the NVIDIA licensing only comes into picture in binary distribution and not in a source release. Advice is appreciated. Best, Sheng [1] https://github.com/apache/incubator-mxnet/blob/v1.8.x/.gitmodules [2] https://github.com/apache/incubator-mxnet/blob/v1.7.x/.gitmodules On 2020/10/20 23:04:00, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > -1 (binding) Please see [1] and note which sort of issues need to be fixed > before making a new release. > > While it does include the WIP declaimers, it includes several knows issues > that have been outstanding for several releases. It also fails to mention teh > issue with Nvidia licensing and its incompatibility with the Apache license. > The PPMC needs to take action on correcting licensing issues in one release > before creating other releases. > > When comparing to the 1.7 release, new 3rd part code has been added, and the > LICENSE file has not been updated to list all of the included code. The > project needs to follow the terms of 3rd party licenses, which generally > state to including the text of the license and follow ASF policy on licenses. > > Thanks, > Justin > > 1. https://issues.apache.org/jira/browse/LEGAL-469 > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
