Re: [patch] Make vector::at() assertion message more useful (try #2)

[Paul Pluzhnikov]

On Wed, Sep 4, 2013 at 4:26 PM, Paolo Carlini <paolo.carl...@oracle.com> wrote:

> For sure concat_size would not be Ok, isn't uglified.

I didn't uglify it because it's inside __gnu_cxx namespace.
Does it still need uglification?

>>    snprintf_lite(__s, sizeof(__s),
>>                  _N("vector::_M_range_check: __n (which is %zu) >= "
>>                     "this->size() (which is %zu)"), __n, this->size());
>
> That seems worth exploring, I agree.

Should snprintf_lite be in __gnu_cxx namespace, or be global and be called
__snprintf_lite(), or ...?

Is the location of the out-of-line code in libstdc++-v3/libsupc++/ ok?
(Would probably be called snprintf_lite.cc or some such.)

Is the version I've assigned to the symbol -- GLIBCXX_3.4.20 -- ok?

Thanks,
-- 
Paul Pluzhnikov