On Tue, Dec 24, 2019 at 10:24:55AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Dec 20, 2019 at 06:55:53PM -0500, Michael Meissner wrote: > > * config/rs6000/rs6000.c (rs6000_reg_to_addr_mask): New helper > > function to identify the address mask of a hard register. > > Do this as a separate patch please. That refactoring is pre-approved. > Please explain in the function comment what an "address mask" is. Or > better yet, don't call it a "mask", it isn't a mask?
It is called mask because everywhere else in rs6000.c uses 'addr_mask' or just mask. It is a mask of valid bits. > Also various of the names here still have "reload" in it, which doesn't > really make much sense. When these functions were written, it was in the context of supporting the secondary reload functions, and so reload was in the name. I will make a refactoring patch that uses the current names. If we want to change all of the uses we can in a future patch. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
