On Tue, Dec 24, 2019 at 10:24:55AM -0600, Segher Boessenkool wrote: > Hi! > > On Fri, Dec 20, 2019 at 06:55:53PM -0500, Michael Meissner wrote: > > * config/rs6000/rs6000.c (rs6000_reg_to_addr_mask): New helper > > function to identify the address mask of a hard register. > > Do this as a separate patch please. That refactoring is pre-approved. > Please explain in the function comment what an "address mask" is. Or > better yet, don't call it a "mask", it isn't a mask? > > Also various of the names here still have "reload" in it, which doesn't > really make much sense. > > rs6000_mode_to_addressing_flags? And a reg_to for this new one? > Something like that.
Note, rs6000_mode_to_addressing_flags also does not fit the usage. The key is to return the address mask of the valid addressing options that needs both a hard register and a mode. Mode by itself is not useful, since loading up SImode to vector registers requires X_FORM, while then same mode in GPR registers can of course do D_FORM and X_FORM addressing. -- Michael Meissner, IBM IBM, M/S 2506R, 550 King Street, Littleton, MA 01460-6245, USA email: meiss...@linux.ibm.com, phone: +1 (978) 899-4797
