On 20 Apr 2015, at 10:47, Dominique d'Humières wrote: > After having fixed the typo, regtesting went without regression.
I have done a bootstrap on i686-darwin10 with the amended patch - slow machine, so testing still in progress (but looks OK so far), NOTE: that there some references to reload_in_progress in config/darwin.c pic code shared between powerpc and x86 darwin implementations. I will do a follow-up patch to make those assert if triggered on x86 (AFAIK, they still need to be present for powerpc, at present). Iain > > Dominique > >> Le 19 avr. 2015 à 20:35, Uros Bizjak <ubiz...@gmail.com> a écrit : >> >> Hello! >> >> Attached patch removes reload_in_progress checks for x86 (LRA enabled) >> target. AFAICS, reload_in_progress is never set during the >> compilation, a watchpoint on this variable didn't trigger for a couple >> of complex compilations. >> >> 2015-04-19 Uros Bizjak <ubiz...@gmail.com> >> >> * config/i386/i386.c (set_pic_reg_ever_live): Remove. >> (legitimize_pic_address): Do not call set_pic_reg_ever_live. >> (legitimize_tls_address): Ditto. >> (ix86_expand_move): Ditto. >> (ix86_expand_binary_operator): Remove reload_in_progress checks. >> (ix86_expand_unary_operator): Ditto. >> * config/i386/predicates.md (index_register_operand): Ditto. >> >> Patch was bootstrapped on x86_64-linux-gnu and regression tested for >> x86_64-linux-gnu, i686-linux-gnu with and w/o -fpic. >> >> The patch also changes Darwin specific code that can't be tested >> properly on linux. Instead of leaving a reload_in_progress_check >> theere, I'd ask someone to bootstrap and regression test the patch on >> Darwin target. >> >> I'll wait for the Darwin regression test results (and possible >> comments) before committing the patch. >> >> Uros. >> <p.diff.txt> >
