Hi,
> Gesendet: Sonntag, 12. Februar 2017 um 03:16 Uhr
> Von: "Michael T. Pope" <[email protected]>
> An: [email protected]
> Betreff: Re: [Freecol-developers] River styles
>
> On Sun, 12 Feb 2017 12:02:55 +1030
> "Michael T. Pope" <[email protected]> wrote:
> > > Btw., I could not get the integrity checker to output something useful:
> > > $ ant validate-savegame
> > > -Dsavegame=../../freecol/save/14e3a40e_Niederländisch_1508.fsg
> >
> > OK, that one is validating the game against the schema. I will look into
> > what is happening there.
>
> Simple omission in the schema. Fixed in git.40feb43. Your game now
> passes schema-validation.
Sorry, but for me (git.70910a33) not:
$ ant validate-savegame
-Dsavegame=../../freecol/save/14e3a40e_Niederländisch_1508.fsg
Buildfile: C:\Users\Sebastian\Documents\NetBeansProjects\FreeCol\build.xml
init:
compile:
build:
validate-savegame:
[java] Processing file ..\..\freecol\save\14e3a40e_Niederl▒ndisch_1508.fsg
[java] cvc-complex-type.2.4.a: Ung▒ltiger Content wurde beginnend mit
Element 'serverGame' gefunden. '{serverPlayer, serverUnit,
serverIndianSettlement}' wird erwartet. at line=15 column=350
BUILD SUCCESSFUL
Total time: 1 second
> Meanwhile, the integrity tester fails due to bad tile improvements, but the
> log shows that the fixes worked[1]. The same applies to the game attached
> to BR#3025 --- do you know what the problem was there?
>
> [1] git.94c72d7 improves the --check-savegame messages to distinguish the
> failed-but-fixed case and to point to the log file.
You mean later than git.f3288756 ? TileImprovement.checkIntegrity is
relying on update[Road/River]Style methods to fix something and only
reports something if these changed something.
That means it could not report problems earlier, but null roads exist
in nearly all savegames, which means 99.99% of all savegames will
show "failed, but fixed" now (unless someone exterminated all Indians,
removing the unconnected virtual roads inside their settlements,
and all European roads have a neighbouring road to connect to,
including virtual ones for colonies).
You can pretty much ignore all messages with
"WARNING: Fixing improvement style from null to 00000000 at "
for the moment. I assume there was some other problem in BR#3025,
but more information on it would have been nice.
You could try the branch from my github on some savegames, as it
catches and prints a few other problems with the improvement styles,
but most likely will __not__ catch the problem from BR#3025, too.
Theres the philosophical question left on if the null rivers were
a bug in updateRoadStyle or just the accepted old savegame format.
The old message treats it as a bug now, but one might argue that
if its just been the normal save format it could just silently
fix it until 0.13.0.
Greetings,
wintertime
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freecol-developers
