On Sun, 12 Feb 2017 12:02:55 +1030
"Michael T. Pope" <[email protected]> wrote:
On Fri, 10 Feb 2017 22:56:50 +0100
[email protected] wrote:
> I upgraded the code for checking roads/rivers have no style problems,
> as I had looked at it so much recently and the compat code is going
> to be upgraded soon.
> Its at: https://github.com/wintertime/FreeCol/tree/cleanup-improvements
> I tried to get it to work correctly, but doublechecking and more testing
> would be useful, as I always avoided touching the serialization code
> until now.  

Ran some tests and could not break anything, including the harder serialization
tests.  You are right that a lot of games now have integrity that is
failed-but-fixed, but I think this is the Right Thing to do.  We should be
clear as to what format is expected.  So this is looking good.

> Sorry, but for me (git.70910a33) not:
> $ ant validate-savegame 
> -Dsavegame=../../freecol/save/14e3a40e_Niederländisch_1508.fsg

Ugh.  validate-savegame fails if you mistype the file name:-P.  Should be
fixed in git.2500200.  Apparently the saved game schema is long neglected.
More fixes there are almost certainly needed.

Cheers,
Mike Pope

Attachment: pgp6r8FuhNVa4.pgp
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to