Hi, I was trying to improve how rivers are handled by the map editor, which currently is annoying to use. It seems that TileImprovement.updateRiverConnections got 3 conflicting uses requiring different handling. 1. right click on a land tile without river to add a river in map editor, where it should probably autoconnect to neighboring tiles 2. setting a river style through the RiverStyleDialog in map editor, where it should just --set-- the selected style 3. TileImprovement.checkIntegrity where some 0.10.5 compatibility code tries to validate if there are wrong connections between river and road tiles For 3. I need to know how these old maps were bugged. Is it still necessary to autoconnect river tiles or would be enough to delete superfluous connections? That would determine if I'd need to split that method.
For the map editor, I think I will change both river buttons in the panel to work like the other buttons in that a right click is just adding or removing the improvement and not annoyingly opening the dialog for choosing the style every click into a rivertile. Then I'd add a separate button for choosing a style, where I then open the river style dialog, without the delete button inside it. There I would like to know, is it permissible to set combined river styles like 1012? Currently such styles get silently ignored and transformed into something like 1011 or 2022, which I find unintuitive and limiting. I'd like to allow this, but the other option is downsizing the river style dialog and removing all "duplicated styles" with same connections but different river widths, which would just provide nicer looking maps without being gameplay-relevant. What do you think? Greetings, wintertime ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
