On Fri, 10 Feb 2017 22:56:50 +0100 [email protected] wrote: > I upgraded the code for checking roads/rivers have no style problems, > as I had looked at it so much recently and the compat code is going > to be upgraded soon. > Its at: https://github.com/wintertime/FreeCol/tree/cleanup-improvements > I tried to get it to work correctly, but doublechecking and more testing > would be useful, as I always avoided touching the serialization code > until now.
Will test. > I also pushed a commit fixing null style rivers into the FreeCol repo, > after I found some with the updated code inside one of my own saves. > I also used your savegame for testing for all kinds of river/road problems > and there is null roads, rivers with broken connection, rivers > with 0000 style, but no rivers with null style. :) > I dont really need another save with null style rivers, but I'm not sure > if null style rivers actually existed or if I could simplify that code? I am not sure either now. The change to river styles was not my code. Later when trying to fix the broken maps I recall being deeply confused about what used to be valid, so I tried to be generous in what we read (so potentially including nonexisting cases), and conservative in what we wrote. > In my own save I also found a few null roads were duplicated, is that a bug? I think so, but not a serious one. > I only saw that when checking the output from the updated readAttributes > for correctness in the logfile. It looks like other parts of the game > might not be accessing the duplicate, as it keeps the null style and gets > resaved that way. I'll attach the save and log file. > Examples you can search for: > tile:3139 > tile:9240 Which save game? I do not see any duplicates in the attached one for tile:3139. > Btw., I could not get the integrity checker to output something useful: > $ ant validate-savegame > -Dsavegame=../../freecol/save/14e3a40e_Niederländisch_1508.fsg OK, that one is validating the game against the schema. I will look into what is happening there. However that is a different thing from the integrity checker, as in the checkIntegrity stuff in the code, which I get to with the --check-savegame argument on the FreeCol command line. Cheers, Mike Pope
pgpeZumLwdwsF.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
