On 20.10.2012 13:57, Michael T. Pope wrote:
> On Fri, 19 Oct 2012 07:05:37 AM Michael Vehrs wrote:
>    
>> At the moment, forests obscure rivers on the same tile.
>>      
> Quite so, BR#2974004.
>
>    
>> This looks like a lot of work, but it isn't, really.
>>      
> Hope so!  I can not comment meaningfully knowing very little about this part
> of FreeCol, but this certainly should be fixed.  Exploring Brazil on
> America_large is painful without being able to see the Amazon system.
>
> Cheers,
> Mike Pope
>    

I have been thinking about this issue some more. At the moment, we 
encode rivers using ternary numbers, which is very compact, but not 
amenable to bit-twiddling. I think it  would be better to switch to 
base-four, which should allow for a cheap solution to bug #2988291: 
River movement bonus using something like

   if (river_style & mask[direction] > 0) ...

However, this would probably require bumping the savegame version in 
order to distinguish between rivers encoded as base-three and base-four. 
Any objections to that?


Regards

Michael



------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
Freecol-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to