Daniel Erez has posted comments on this change.
Change subject: core: Introducing VersionStorageFormatUtil
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
Line 12: public class VersionStorageFormatUtil {
Line 13: private static final Map<Version, StorageFormatType>
versionToFormat = new HashMap<Version, StorageFormatType>() {
Line 14: {
Line 15: put(Version.v2_2, StorageFormatType.V1);
Line 16: put(Version.v3_0, StorageFormatType.V2);
consider adding a comment that StorageFormatType.V2 is only for block SDs
Line 17: put(Version.v3_1, StorageFormatType.V3);
Line 18: put(Version.v3_2, StorageFormatType.V3);
Line 19: put(Version.v3_3, StorageFormatType.V3);
Line 20: }
--
To view, visit http://gerrit.ovirt.org/18697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
