Maor Lipchuk has posted comments on this change.
Change subject: core: Introducing VersionStorageFormatUtil
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
Line 154: }
Line 155: final StorageDomainStatic staticDomain =
storageDomain.getStorageStaticData();
Line 156: boolean staticDomainChanged = false;
Line 157: // for data centers >= 3.1 we enforce the
domain version to V3
Line 158: // this strictly needs to be before selecting
the masterStorageDomain because the pool master
I think that this comment can be removed now (might be more appropriate to put
it in VersionStorageFormatUtilthe
Line 159: // version (setmaster_domain_version) depends
on the domain upgrade.
Line 160: StorageFormatType requiredFormatType =
Line 161:
VersionStorageFormatUtil.getFormatForVersion(getStoragePool().getcompatibility_version());
Line 162: if (staticDomain.getStorageFormat() !=
requiredFormatType) {
Line 157: // for data centers >= 3.1 we enforce the
domain version to V3
Line 158: // this strictly needs to be before selecting
the masterStorageDomain because the pool master
Line 159: // version (setmaster_domain_version) depends
on the domain upgrade.
Line 160: StorageFormatType requiredFormatType =
Line 161:
VersionStorageFormatUtil.getFormatForVersion(getStoragePool().getcompatibility_version());
IINM, I think there is a change in the behaviour here.
Before the change we only set the storage format in the staticDomain if the
storage pool was greater then version 3.1
Now we change the storage format for all storage pool versions.
I'm not sure, but I think it will make checkStorageDomainsInPool validation not
relevant any more?
Line 162: if (staticDomain.getStorageFormat() !=
requiredFormatType) {
Line 163: if (!staticDomainChanged) {
Line 164:
getCompensationContext().snapshotEntity(staticDomain);
Line 165: }
--
To view, visit http://gerrit.ovirt.org/18697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
