Maor Lipchuk has posted comments on this change. Change subject: core: Introducing VersionStorageFormatUtil ......................................................................
Patch Set 2: 1. I would consider to add a StorageFormatType as a private parameter in the version class. We can benefit the following: 1. We will avoid adding a new map class which we will need to maintain in the future. 2. Developers will not forget to add the storage format type on each new version. 3. We can use default value for StorageFormatType. 2. Please also change AddStoragePoolWithStoragesCommand accordingly. -- To view, visit http://gerrit.ovirt.org/18697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
