Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file ......................................................................
Patch Set 2: Code-Review+2 - worth mentioning (either in branding.properties and/or at the top of messages.properties + resources.properties) that messages.properties should be used to store brandable text that should typically be translated, and resources.properties should be used to store brandable strings that don't typically require translation (e.g. URLs). - please remove from the patch the changes to the non-English .properties files - these are auto-generated from Zanata and shouldn't be manipulated manually (unless not manipulating them manually will result in "compilation"/run-time error to the application) -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
