Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file ......................................................................
Patch Set 2: Hi Alon, we don't fetch the translations during make (although I must admit that it sounds like a very interesting idea...). I meant that typically, translation-updates are always pushed in separate patches which contain the non-English .properties files that are auto-generated from Zanata (i.e. without any manual intervention) - see http://gerrit.ovirt.org/#/q/owner:ecohen+message:translation,n,z for examples for such patches. Because these files are completely auto-generated, there is no point in changing them manually, since in the next pull-and-auto-generate-from-Zanata, these changes will be overridden. The only exception in which changes to the .non-English files should be made in "regular" patches is when NOT changing the non-English .properties files is causing a compilation/run-time error. -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
