Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/branding/ovirt.brand/resources.properties Line 1: # Feedback URL Line 2: obrand.webadmin.feedback_url=mailto:us...@ovirt.org the system doesn't force me to do anything; I can leave messages untranslated, but it will result in inaccurate translation-completion statistics. I might be able to forcibly mark an empty translation as "completed", however the translators will need to be aware of this exception (which might seem weird from their point of view). Moreover, there is a chance that it will result in having a certain locale overriding the default value with an empty value, which we probably don't want to do. So instead of making the translation-management system do things that it doesn't suppose to do (e.g. manage strings that don't qualify as "translations"), I suggest to separate the relevant strings to a new file, which is exactly what this patch does. The important thing to keep in mind is that people that contribute/in charge of text translations aren't necessarily (or most likely are NOT) the same people that will determine the feedback link URL. That's why separating these files makes sense. Line 3: Line 4: # Guide URL Line 5: obrand.webadmin.guide_url=http://www.ovirt.org/Documentation Line 6: obrand.userportal.guide_url=http://www.ovirt.org/Documentation -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
