Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file ......................................................................
Patch Set 3: Code-Review+2 (1 comment) minor inline comments. also question: will this change actually include the change introduced in http://gerrit.ovirt.org/#/c/18828/ (so http://gerrit.ovirt.org/#/c/18828/ will need to be abandoned if this patch is merged)? .................................................... File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/branding/BrandingManager.java Line 208: // And later messages should override earlier ones. Line 209: keyValues.put(key.replaceFirst(BRAND_PREFIX + "\\." //$NON-NLS-1$ Line 210: + prefix + "\\.", "") //$NON-NLS-1$ Line 211: .replaceFirst(COMMON_PREFIX + "\\.", "") //$NON-NLS-1$ Line 212: .replaceFirst(BRAND_PREFIX + "\\.", ""), //$NON-NLS-1$ //$NON-NLS-2$ //Blank prefix - change tabs to spaces - remove trailing white space at the end of the line Line 213: messagesBundle.getString(key)); Line 214: } Line 215: } Line 216: } -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
