Einav Cohen has posted comments on this change. Change subject: userportal,webadmin: split messages in two file ......................................................................
Patch Set 1: (1 comment) .................................................... File packaging/branding/ovirt.brand/resources.properties Line 1: # Feedback URL Line 2: obrand.webadmin.feedback_url=mailto:us...@ovirt.org the entire point of this patch was to separate the strings that require translation from the strings that don't require translation. currently (i.e. without this patch), due to the fact that we are using Zanata as our translation-management system, and due to the fact that the values of these particular strings is identical across locales (at least now), it would result in having these values duplicated in all .properties files in all locales, and I was hoping to avoid that. having said that, I agree that having different URLs in different locales is a possible/valid use-case which makes sense, however this is not "translation" (there is a difference between "translation" and "supply different values per locale"), hence this is not something that needs/expected to be managed via a translation-management system (like Zanata), hence the file separation introduced in this patch does make sense. As mentioned by Alon - these strings can still be "localized", i.e., values can still be provided per locale (e.g. I assume that one can create "resources_ja_JP.properties" that will override the values in this (default) file in case the application's current locale is "ja_JP"). Correct? Line 3: Line 4: # Guide URL Line 5: obrand.webadmin.guide_url=http://www.ovirt.org/Documentation Line 6: obrand.userportal.guide_url=http://www.ovirt.org/Documentation -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
