Alon Bar-Lev has posted comments on this change. Change subject: userportal,webadmin: split messages in two file ......................................................................
Patch Set 1: (3 comments) .................................................... File packaging/branding/ovirt.brand/branding.properties Line 14 Line 15 Line 16 Line 17 Line 18 You will need to submit this to ovirt-engine-3.3 branch anyway, as older cannot read the comma-separated list. .................................................... File packaging/branding/ovirt.brand/resources.properties Line 1: # Feedback URL Line 2: obrand.webadmin.feedback_url=mailto:us...@ovirt.org No one have... but it is valid requirement, I would not have rejected the option. But as it is, these strings can be localized as well, so we are good. Line 3: Line 4: # Guide URL Line 5: obrand.webadmin.guide_url=http://www.ovirt.org/Documentation Line 6: obrand.userportal.guide_url=http://www.ovirt.org/Documentation Line 1: # Feedback URL Line 2: obrand.webadmin.feedback_url=mailto:us...@ovirt.org Line 3: Line 4: # Guide URL Line 5: obrand.webadmin.guide_url=http://www.ovirt.org/Documentation So best to allow localization of these... instead of having a template with language etc... Line 6: obrand.userportal.guide_url=http://www.ovirt.org/Documentation -- To view, visit http://gerrit.ovirt.org/18623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e5301cb7e4f03f976125b9814f06b28e4f97d5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
