Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: Separate remove and add
......................................................................
Patch Set 12:
(1 comment)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 259: # Disabling existing services before configuration reload
Line 260: # because the service file may be emptied or removed in misc
stage by
Line 261: # the plugins requesting this action and in this case reload
will fail
Line 262: #
Line 263: self._disabled_zones_services = {}
you appended the transaction above without initializing this variable... better
move it into constructor.
Line 264: zones_services = self._get_zones_services()
Line 265: self.logger.debug('zones_services = %s', zones_services)
Line 266: for zone in zones_services:
Line 267: for service in self.environment[
--
To view, visit http://gerrit.ovirt.org/18476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d
Gerrit-PatchSet: 12
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
