Yedidyah Bar David has posted comments on this change. Change subject: network: firewalld: Separate remove and add ......................................................................
Patch Set 7: (1 comment) .................................................... File src/plugins/otopi/network/firewalld.py Line 50 Line 51 Line 52 Line 53 Line 54 Note that there is a bug here, you get only the first interface. But the code does not look at the interfaces. Still might be better to fix. -- To view, visit http://gerrit.ovirt.org/18476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d Gerrit-PatchSet: 7 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches