Yedidyah Bar David has posted comments on this change.
Change subject: network: firewalld: Separate remove and add
......................................................................
Patch Set 8:
(2 comments)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 56: def prepare(self):
Line 57: pass
Line 58:
Line 59: def abort(self):
Line 60: for zone in self._parent._disabled_zones_services:
It's removed from python 3. What would you prefer?
Line 61: for service in
self._parent._disabled_zones_services[zone]:
Line 62: self._parent.execute(
Line 63: (
Line 64: self._parent.command.get('firewall-cmd'),
Line 63: (
Line 64: self._parent.command.get('firewall-cmd'),
Line 65: '--zone', zone,
Line 66: '--permanent',
Line 67: '--add-service', service,
Done
Line 68: ),
Line 69: )
Line 70:
Line 71: def commit(self):
--
To view, visit http://gerrit.ovirt.org/18476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d
Gerrit-PatchSet: 8
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
