Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: Separate remove and add
......................................................................
Patch Set 4:
(3 comments)
....................................................
File src/plugins/otopi/network/firewalld.py
Line 57: pass
Line 58:
Line 59: def abort(self):
Line 60: for zone in self._zones:
Line 61: for service in self._disabled_services:
but why don't you use the environment directly? why do you need a member clone?
Line 62: self.execute(
Line 63: (
Line 64: self.command.get('firewall-cmd'),
Line 65: '--zone', zone,
Line 64: self.command.get('firewall-cmd'),
Line 65: '--zone', zone,
Line 66: '--permanent',
Line 67: '--add-service', service,
Line 68: ),
usually abort is not designed to fail, as there is no sense in that... the
abort cycle must continue... for example if you fail one service, I still
expect other service to be re-enabled...
Line 69: )
Line 70:
Line 71: def commit(self):
Line 72: pass
Line 232: (
Line 233: self.command.get('firewall-cmd'),
Line 234: '--zone', zone,
Line 235: '--permanent',
Line 236: '--remove-service', service,
yes, I know... not sure the existing code is ok as well...
I suggest to ignore error anyway so we make sure we disable as much as we can,
and if these guys will come around and return proper exit status we still work.
Line 237: ),
Line 238: )
Line 239:
Line 240: @plugin.event(
--
To view, visit http://gerrit.ovirt.org/18476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e033abf45888b98cac3c87d04bd744e7555ca4d
Gerrit-PatchSet: 4
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
