Ravi Nori has posted comments on this change. Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot ......................................................................
Patch Set 6: Verified+1 Here is how things work right now. taskGroupSuccess is initialized to true in VdcActionParametersBase. It is set to false in endCommandWithFailure in each command. The right way of doing it as Liron suggested to initialize taskGroupSucess to false and have each command determine if it failed/succeeded in endAction. Not sure if we want to do that in this patch Yair/Allon please let me know. -- To view, visit http://gerrit.ovirt.org/17590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
