Liron Ar has posted comments on this change. Change subject: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm after failure in create snapshot ......................................................................
Patch Set 6: @Yair @Allon - bad wording on the last comment, sorry - i didn't mean to the default, but to that the taskGroupSuccess should be always set to the correct value, either true or false. I think that the solution and the bug here is that taskGroupSuccess doesn't have the correct value - the issue is general and affect all flows and not related only to this one, i don't see any scenario in which we would want the task group success to be true when not all tasks were created/succeeded (BTW- seems to me like it's possibly a regression? because our revert flows rely on that) -- To view, visit http://gerrit.ovirt.org/17590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
