Maor Lipchuk has posted comments on this change.
Change subject: engine : Null Pointer Exception for action
CreateAllSnapshotsFromVm after failure in create snapshot
......................................................................
Patch Set 4:
(2 comments)
....................................................
Commit Message
Line 5: CommitDate: 2013-08-06 10:52:34 -0400
Line 6:
Line 7: engine : Null Pointer Exception for action CreateAllSnapshotsFromVm
after failure in create snapshot
Line 8:
Line 9: After a failure in create snapshot, engine enters in to
s/in to/into
Line 10: a loop with NullPointerException. This patch fixes the
Line 11: case where the vdsm was restarted after submission of the
Line 12: command and the entry in snapshots table was cleared by engine
Line 13: leading to NPE in CreateAllSnapshotsFromVmCommand.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 132: addSnapshotToDB(createdSnapshotId, memoryImageBuilder);
Line 133: createSnapshotsForDisks();
Line 134: memoryImageBuilder.build();
Line 135:
Line 136: if (getTaskIdList().isEmpty()) {
Here you are initializing the taskGroupSuccess with true while it is true by
default.
We should set the task group success with false and only then update it to true
Line 137: getParameters().setTaskGroupSuccess(true);
Line 138: incrementVmGeneration();
Line 139: }
Line 140:
--
To view, visit http://gerrit.ovirt.org/17590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
