Maor Lipchuk has posted comments on this change.
Change subject: engine : Null Pointer Exception for action
CreateAllSnapshotsFromVm after failure in create snapshot
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 132: addSnapshotToDB(createdSnapshotId, memoryImageBuilder);
Line 133: createSnapshotsForDisks();
Line 134: memoryImageBuilder.build();
Line 135:
Line 136: getParameters().setTaskGroupSuccess(false);
Ravi, if you just initialize this with false before the creation of the tasks
then your fix will be perfect.
Line 137: if (getTaskIdList().isEmpty()) {
Line 138: incrementVmGeneration();
Line 139: }
Line 140:
--
To view, visit http://gerrit.ovirt.org/17590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
