Alon Bar-Lev has posted comments on this change.
Change subject: WIP: packaging: setup: Add host rename script
......................................................................
Patch Set 12: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/database.py
Line 74: except RuntimeError:
Line 75: self.logger.debug(
Line 76: "Option {option} not found in db".format(
Line 77: option=option
Line 78: )
Options should always exist[1].... this is bad design of options in product...
[1]
http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql;hb=HEAD#l409
Line 79: )
Line 80: return
Line 81:
Line 82:
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py
Line 122:
Line 123: if (
Line 124: externally_modified_files and
Line 125: self.environment[
Line 126: osetupcons.RenameEnv.CONFIRM_FORCE_OVERWRITE]
pep8 happy and consistent styling.
For example, there is approach to align based on the function name:
xxx(parameter1=value,
parameter2=value)
xxxxxxxxxxx(parameter1=value,
parameter2=value)
Which is inconsistent, both in indent size, the visualization of what belongs
which bloc, and the ability to add parameter3 or change value1 or function name
without touching any other line.
Line 127: ):
Line 128: self.logger.warn(
Line 129: _(
Line 130: 'The following files were externally modified -
outside '
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
