Alon Bar-Lev has posted comments on this change.
Change subject: WIP: packaging: setup: Add host rename script
......................................................................
Patch Set 12: (4 inline comments)
....................................................
File packaging/setup/bin/ovirt-engine-rename
Line 31: Load configuration files.
Line 32: --config-append=file
Line 33: Load extra configuration files.
Line 34: --generate-answer=file
Line 35: Generate answer file.
--newname reminder.
Line 36:
Line 37: __EOF__
Line 38: exit 1
Line 39: }
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/database.py
Line 70: 'value': newvalue,
Line 71: },
Line 72: )
Line 73: )
Line 74: except RuntimeError:
just let it be thrown...
Line 75: self.logger.debug(
Line 76: "Option {option} not found in db".format(
Line 77: option=option
Line 78: )
Line 74: except RuntimeError:
Line 75: self.logger.debug(
Line 76: "Option {option} not found in db".format(
Line 77: option=option
Line 78: )
Cannot set {option} would be better as you don't know what the error is... and
you should also present the real error:
except RuntimeException as e:
..."Cannot set option '{option}', error: {error}".format(
option=option.
error=e,
)
But as this is debug anyway... and we will see the exception in the log, just
allow it to be thrown.
Line 79: )
Line 80: return
Line 81:
Line 82:
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/uninstall.py
Line 122:
Line 123: if (
Line 124: externally_modified_files and
Line 125: self.environment[
Line 126: osetupcons.RenameEnv.CONFIRM_FORCE_OVERWRITE]
']' is out of place :)
either:
aaa[bbb]
or:
aaa[
bbb
]
Line 127: ):
Line 128: self.logger.warn(
Line 129: _(
Line 130: 'The following files were externally modified -
outside '
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
