Alon Bar-Lev has posted comments on this change.
Change subject: WIP: packaging: setup: Add host rename script
......................................................................
Patch Set 11: (4 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/database.py
Line 55: except RuntimeError:
Line 56: self.logger.debug("Option {option} not found in db".format(
Line 57: option=option
Line 58: )
Line 59: return
you really don't need this return.
Line 60:
Line 61: pattern=r"""
Line 62: (?P<proto>[a-z]+)
Line 63: ://
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/pki.py
Line 67: osetupcons.Defaults.DEFAULT_PKI_COUNTRY
Line 68: )
Line 69: self.environment.setdefault(
Line 70: osetupcons.PKIEnv.ORG,
Line 71: None
We agreed to parse, no?
Line 72: )
Line 73:
Line 74: @plugin.event(
Line 75: stage=plugin.Stages.STAGE_SETUP,
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/protocols.py
Line 79: )
Line 80: self.environment.setdefault(
Line 81: osetupcons.ConfigEnv.JBOSS_DIRECT_HTTPS_PORT,
Line 82: None
Line 83: )
We agreed not to use this approach, right?
Line 84:
Line 85: @plugin.event(
Line 86: stage=plugin.Stages.STAGE_SETUP,
Line 87: )
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/tools.py
Line 39:
Line 40: TOOLS_CONFIG = [
Line 41: {
Line 42: "dir": "{engine_sysconf}/isouploader.conf.d",
Line 43: "section": "ISOUploader",
please use 'string' quotation when possible.
Line 44: },
Line 45: {
Line 46: "dir": "{engine_sysconf}/imageuploader.conf.d",
Line 47: "section": "ImageUploader",
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
