Yedidyah Bar David has posted comments on this change. Change subject: WIP: packaging: setup: Add host rename script ......................................................................
Patch Set 12: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/misc.py Line 66: None Line 67: ) Line 68: Line 69: @plugin.event( Line 70: stage=plugin.Stages.STAGE_VALIDATION, BTW, Alon, why did you put it in validation? Shouldn't it be customization? (copied from http://gerrit.ovirt.org/16979) Line 71: ) Line 72: def _validation(self): Line 73: if self.environment[ Line 74: osetupcons.RenameEnv.FQDN -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
