Sandro Bonazzola has posted comments on this change. Change subject: WIP: packaging: setup: host rename ......................................................................
Patch Set 11: (2 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/database.py Line 44: @plugin.event( Line 45: stage=plugin.Stages.STAGE_MISC, Line 46: after=[ Line 47: osetupcons.Stages.DB_CONNECTION_AVAILABLE, Line 48: ], latest patches submitted by Alon uses tuple instead of lists Line 49: ) Line 50: def _misc(self): Line 51: option = 'RedirectServletReportsPage' Line 52: try: .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/postinstall.py Line 38: Line 39: Line 40: @util.export Line 41: class Plugin(plugin.PluginBase): Line 42: """post install config file plugin.""" Have you verified what happens running engine-setup-2 after rename has updated the post install config? Line 43: Line 44: def __init__(self, context): Line 45: super(Plugin, self).__init__(context=context) Line 46: -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
