Yedidyah Bar David has posted comments on this change. Change subject: WIP: packaging: setup: host rename ......................................................................
Patch Set 5: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/protocols.py Line 81: self.environment[ Line 82: osetupcons.ConfigEnv.HTTPS_PORT Line 83: ] = self.environment[ Line 84: osetupcons.ConfigEnv.JBOSS_HTTPS_PORT Line 85: ] Updated. This makes me think again if I want to prevent code duplication... Line 86: self.environment[ Line 87: otopicons.CoreEnv.MODIFIED_FILES Line 88: ].append( Line 89: osetupcons.FileLocations. -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
