Alon Bar-Lev has posted comments on this change.
Change subject: packaging: added DB validation functions
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
Line 134: '-q',
Line 135: ),
Line 136: raiseOnError=False,
Line 137: envAppend={
Line 138: 'PGPASSFILE': self.environment[
all our dbscripts utilities should get ENGINE_PGPASS, if it is not the case we
should fix these.
Line 139: osetupcons.DBEnv.PGPASS_FILE
Line 140: ]
Line 141: },
Line 142: )
....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/dbvalidations.py
Line 106: )
Line 107: def _setup(self):
Line 108: self._enabled = os.path.exists(
Line 109: osetupcons.FileLocations.OVIRT_ENGINE_PKI_ENGINE_CA_CERT
Line 110: )
upgrade is an upgrade, you can use the generic detection, or use the new
database env key.
I also think that you can perform this in any case, as new database will not
have pending tasks, right?
Line 111:
Line 112: @plugin.event(
Line 113: stage=plugin.Stages.STAGE_VALIDATION,
Line 114: priority=plugin.Stages.PRIORITY_LOW,
--
To view, visit http://gerrit.ovirt.org/15970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
