Alon Bar-Lev has posted comments on this change.
Change subject: packaging: added DB validation functions
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
Line 52: self._dbstatement = dbstatement
Line 53:
Line 54: def _setEngineMode(self, maintenance=True, timeout=0):
Line 55: if maintenance:
Line 56: self._origTimeout = self._dbstatement.getVDCOption(
righso add a new function of _getCurrentTimeout() or something... it has
nothing to do with _setEngineMode(), it is unexpected you store state within.
Call_getCurrentTimeout() at __enter__ and store it within the member.
Line 57: name='AsyncTaskZombieTaskLifeInMinutes',
Line 58: )
Line 59: mode = 'MAINTENANCE'
Line 60: else:
Line 165: '---- Task ID: {task_id:30} -------\n'
Line 166: 'Task Name: {task_name:>30}\n'
Line 167: 'Task Description: \t{task_desc:>30}\n'
Line 168: 'Started at: {started_at:>30}\n'
Line 169: 'DC Name: {name:>30}'
?
Line 170: ).format(
Line 171: task_id=entry['task_id'],
Line 172:
task_name=ASYNC_TASKS_MAP[entry['action_type']][0],
Line 173:
task_desc=ASYNC_TASKS_MAP[entry['action_type']][1],
--
To view, visit http://gerrit.ovirt.org/15970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
