Alex Lourie has posted comments on this change. Change subject: packaging: added DB validation functions ......................................................................
Patch Set 8: (4 inline comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py Line 249: not runningTasks and Line 250: not compensations Line 251: ): Line 252: break Line 253: else: removed. Line 254: self.dialog.note( Line 255: text=_( Line 256: 'Waiting for the completion of {number} ' Line 257: 'running tasks during the next ' Line 292: @plugin.event( Line 293: stage=plugin.Stages.STAGE_VALIDATION, Line 294: condition=lambda self: self.environment[ Line 295: osetupcons.AsyncTasksEnv.CLEAR_TASKS Line 296: ] is True removed. Line 297: ) Line 298: def _validateZombies(self): Line 299: self.logger.info( Line 300: _('Cleaning stale zombie tasks') Line 305: stage=plugin.Stages.STAGE_VALIDATION, Line 306: priority=plugin.Stages.PRIORITY_LOW, Line 307: condition=lambda self: self.environment[ Line 308: osetupcons.AsyncTasksEnv.CLEAR_TASKS Line 309: ] is True removed. Line 310: ) Line 311: def _validateAsyncTasks(self): Line 312: self.logger.info( Line 313: _('Cleaning async tasks and compensations') Line 318: dbstatement = database.Statement(self.environment) Line 319: try: Line 320: self._waitForTasksToClear(dbstatement) Line 321: except KeyboardInterrupt: Line 322: raise RuntimeError( Done Line 323: _( Line 324: 'Upgrade cannot be completed; asynchronious ' Line 325: 'tasks or compensations are still running. ' Line 326: 'Please make sure that there are no running ' -- To view, visit http://gerrit.ovirt.org/15970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches