Alon Bar-Lev has posted comments on this change. Change subject: core: i18n splash with branding ......................................................................
Patch Set 1: (2 inline comments) .................................................... File packaging/branding/ovirt.brand/branding.properties Line 11: Line 12: # style sheets. (required, but the files can be empty) Line 13: user_portal_css=user_portal.css Line 14: web_admin_css=web_admin.css Line 15: splash_css=ovirt-engine-style.css better to have this without ovirt-engine to allow simple diff between two branding packages, this is why I removed the ovirt from the above as well. for the splash... the fact that it was called this way so far and the bug is named after that, does not mean that this is clear to anyone outside of ui core developers.... I suggest to rename splash->welcome at all places. splash is usually a window that appear when you start a program, with logo and copyright until program is loaded[1], this is not our case, and if we provide an interface we should use terms that are correct. [1] http://en.wikipedia.org/wiki/Splash_screen Line 16: Line 17: # text (optional, this overrides the default messages) Line 18: messages=messages.properties Line 19: .................................................... File packaging/branding/ovirt.brand/messages.properties Line 46: obrand.splash.section1.row1.url=/UserPortal/org.ovirt.engine.ui.userportal.UserPortal/UserPortal.html?locale={0} Line 47: obrand.splash.section1.row2.text=Administrator Portal Line 48: obrand.splash.section1.row2.url=/webadmin/webadmin/WebAdmin.html?locale={0} Line 49: obrand.splash.section1.row3.text=Reports Portal Line 50: obrand.splash.section1.row3.url=/OvirtEngineWeb/RedirectServlet?Page=Reports I suggest using just index to be similar to other indexing schemes. -- To view, visit http://gerrit.ovirt.org/16359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9987ed58c2e0ead9b25c5f46fb974a96bfd46d30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
