Alex Lourie has posted comments on this change.

Change subject: packaging: added DB validation functions
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File packaging/setup/plugins/ovirt-engine-setup/upgrade/asynctasks.py
Line 309:     )
Line 310:     def _validation(self):
Line 311:         runningTasks, compensations = self._checkRunningTasks()
Line 312:         if runningTasks or compensations:
Line 313:             self._askUserToStopTasks(runningTasks, compensations)
Ok, I understand what you mean; I will update the code.
Line 314: 
Line 315:     @plugin.event(
Line 316:         # NOTE:
Line 317:         # this must run before the package update


-- 
To view, visit http://gerrit.ovirt.org/15970
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25979acbf54d980168be929638ff4aed800bf6d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to