Alon Bar-Lev has posted comments on this change.
Change subject: network: firewalld: fixed firewall-cmd support
......................................................................
Patch Set 2: (3 inline comments)
> there is already an entry about firewalld in ChangeLog:
Right, I forgot we have not yet released..
....................................................
File src/plugins/otopi/network/firewalld.py
Line 42
Line 43
Line 44
Line 45
Line 46
why not just remove the function?
Line 81: state=False,
Line 82: )
Line 83: version_tuple = tuple([int(x) for x in stdout[0].split('.')])
Line 84: version = '%02x%02x%02x' % version_tuple
Line 85: return int(version, 16)
no need for temp vars, maybe:
return int('%02x%02x%02x' % tuple([int(x) for x in stdout[0].split('.')]), 16)
:)
or... support N version components:
int(''.join(['%02x' % int(x) for x in stdout[0].split('.')]), 16)
Line 86:
Line 87: def _get_active_zones(self):
Line 88: rc, stdout, stderr = self.execute(
Line 89: (
Line 91: '--get-active-zones',
Line 92: ),
Line 93: )
Line 94: zones = {}
Line 95: if self._firewalld_version < int('000303', 16):
< 0x00303?
Line 96: for line in stdout:
Line 97: zone_name, devices = line.split(':')
Line 98: zones[zone_name] = devices.split()
Line 99: else:
--
To view, visit http://gerrit.ovirt.org/16094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe22c1f05dc98bc71a6ffd6fe28549721cda4f1
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
